Somebody think the logs appear too frequently.
http://www.osdl.org/developer_bugzilla/show_bug.cgi?id=985

I think the logs are not meaningful also. Anyway, it's better if there are multiple levels for log output in lib. e.g. cl_log2?

Lars Marowsky-Bree wrote:
On 2005-12-05T07:54:32, linux-ha-cvs@lists.linux-ha.org wrote:


linux-ha CVS committal

Author  : sunjd
Host : Project : linux-ha
Module  : lib

Dir     : linux-ha/lib/clplumbing


Modified Files:
ipcsocket.c

Log Message:
disable the logs to output
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/lib/clplumbing/ipcsocket.c,v
retrieving revision 1.163
retrieving revision 1.164
diff -u -3 -r1.163 -r1.164
--- ipcsocket.c 11 Nov 2005 20:39:44 -0000      1.163
+++ ipcsocket.c 5 Dec 2005 14:54:31 -0000       1.164
@@ -1,4 +1,4 @@
-/* $Id: ipcsocket.c,v 1.163 2005/11/11 20:39:44 gshi Exp $ */
+/* $Id: ipcsocket.c,v 1.164 2005/12/05 14:54:31 sunjd Exp $ */
/*
 * ipcsocket unix domain socket implementation of IPC abstraction.
 *
@@ -2091,7 +2091,7 @@
        ||      (size_t)n != sizeof(cred)) {
                return IPC_FAIL;
        }
-#if 1
+#if 0
        cl_log(LOG_DEBUG, "SO_PEERCRED returned [%d, (%ld:%ld)]"
        ,       cred.pid, (long)cred.uid, (long)cred.uid);
        cl_log(LOG_DEBUG, "Verifying authentication: cred.uid=%d cred.gid=%d"


These are already debug logs. What's wrong with them?


Sincerely,
    Lars Marowsky-Brée


--
BRs,

Sun Jiang Dong

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to