Dejan Muhamedagic wrote:
> Hi,
>
> On Mon, Mar 01, 2010 at 01:34:35PM +0100, Cristian Mammoli - Apra Sistemi
> wrote:
>> > > # Check for mandatory files presence and consistency
>> > > vmware_validate() {
>> > > if [ -z "`pidof vmware-hostd`" ]; then
>> > > - ocf_log warn "vmware-hostd is not running"
>> > > - return $OCF_ERR_GENERIC
>> > > + ocf_log err "vmware-hostd is not running: aborting"
>> > > + exit $OCF_ERR_GENERIC
>> > > fi
>>
>> > Changing warn to err and return to exit is obviously fine, but you may
>> > actually want to make this $OCF_ERR_INSTALLED.
>>
>> Ok changed that
>
> As I wrote in another message, I don't think that's good. It is
> going to prevent the CRM from ever trying to start the resource
> on that node (until cleanup/cluster restart).
>
>> I'm working on the changes you suggested
>>
>> P.S. We can't call "validate-all" before "monitor": that causes the
>> script to fail with exit code "2" instead of "7" if called on a node
>> without access to the filesystem containing the VM...
>> I should have checked this stuff deeply :-/
>
> You may want to check this bugzilla:
>
> http://developerbugs.linux-foundation.org/show_bug.cgi?id=2204
>
> In short, for such resource agents, it would be good to act
> differently on probes and monitors.
>
> Cheers,
>
> Dejan
>
>> --
>> Cristian Mammoli
>> APRA SISTEMI srl
>> Via Brodolini,6 Jesi (AN)
>> tel dir. 0731 719822
>>
>> Web www.apra.it
>> e-mail [email protected]
>> _______________________________________________________
>> Linux-HA-Dev: [email protected]
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
--
Cristian Mammoli
APRA SISTEMI srl
Via Brodolini,6 Jesi (AN)
tel dir. 0731 719822
Web www.apra.it
e-mail [email protected]
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
