On Fri, Mar 05, 2010 at 10:32:06AM +0100, Florian Haas wrote: > Attached is a patch that removes the --disable-fatal-warnings flag from > configure in debian/rules for cluster-glue. I seem to recall this was > included because there used to be some compile warnings that fired on > Debian only and were thus not addressed upstream. That seems to no > longer be the case, so that configure flag can be dropped.
It was mainly because I think fatal-warnings by default in released software is stupid. I still do. But if it doesn't cause any bother at the moment I'm happy with this change and will push it into mercurial. > # HG changeset patch > # User Florian Haas <[email protected]> > # Date 1267781114 -3600 > # Branch sid > # Node ID d1ca6b4c3d6ec88776b24772f28587cc494e7ec1 > # Parent 27b1938e1f2c0c3d1812c228d297129ad41dc154 > debian: build with fatal warnings enabled > > There are no longer any warnings that pop up in Debian only. Thus it's > prudent to start building with fatal warnings enabled. > > diff -r 27b1938e1f2c -r d1ca6b4c3d6e debian/rules > --- a/debian/rules Fri Mar 05 09:31:30 2010 +0100 > +++ b/debian/rules Fri Mar 05 10:25:14 2010 +0100 > @@ -37,7 +37,7 @@ > test -x ./configure || ./autogen.sh > ./configure --with-ocf-root=/usr/lib/ocf --with-initdir=/etc/init.d \ > --prefix=/usr --sysconfdir=/etc --localstatedir=/var \ > - --disable-fatal-warnings --mandir=/usr/share/man > --libdir=/usr/lib > + --mandir=/usr/share/man --libdir=/usr/lib > touch configure-stamp > > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
