On 03/25/2010 07:56 PM, Florian Haas wrote: > Finally, exportfs_validate doesn't check on all required parameters. You > want to fix that too.
On second thought, validate is broken altogether. You need to - check all required resource parameters, and exit with $OCF_ERR_CONFIGURED if any are missing (test -z will help); - semantically test all configured resource parameters, and exit with $OCF_ERR_CONFIGURED if they are completely wrong (e.g., fsid not being an integer), or $OCF_ERR_INSTALLED if they can't work on the node where validate is executed (e.g., dir not pointing to a directory). Cheers, Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/