Hi Holger, On Fri, Sep 24, 2010 at 11:30:30AM +0200, holger.teut...@web.de wrote: > Hi, > now that Dejan clarified what get confignames should return a > small fix for external/ipmi.
The stuff which may need all the possible parameters in getconfignames should be retired. But that has to be announced first, etc, not to break the existing installations. I'm inclined to reduce the output to just required parameters, but that is going to happen to all plugins in a single sweep. Alternatively, we may switch to using the meta-data, which is preferable but not sure how complicated. So, we won't apply this fix. Sorry for the confusion. Cheers, Dejan > Regards > Holger > ___________________________________________________________ > GRATIS: Spider-Man 1-3 sowie 300 weitere Videos! > Jetzt kostenlose Movie-FLAT freischalten! http://movieflat.web.de > # HG changeset patch > # User Holger Teutsch <holger.teut...@web.de> > # Date 1285320241 -7200 > # Node ID 4a767aa9969398e492a1bcc5778f5b6401be6e7f > # Parent 0f791595cee4182dcfdb2dfa76a4b1d488c3dfd1 > Low: external/ipmi: getconfignames now returns name for optional parameter > passwd_method > > After Patch 2430 (lib/plugins/stonith/external.c) noise for missing > optional parameters is reduced. > > diff -r 0f791595cee4 -r 4a767aa99693 lib/plugins/stonith/external/ipmi > --- a/lib/plugins/stonith/external/ipmi Wed Sep 15 17:58:44 2010 +0200 > +++ b/lib/plugins/stonith/external/ipmi Fri Sep 24 11:24:01 2010 +0200 > @@ -147,7 +147,7 @@ > exit $? > ;; > getconfignames) > - for i in hostname ipaddr userid passwd interface; do > + for i in hostname ipaddr userid passwd interface passwd_method; do > echo $i > done > exit 0 > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
