On Fri, Dec 10, 2010 at 12:06 PM, Florian Haas <florian.h...@linbit.com> wrote: > On 2010-12-08 18:15, alexander.kra...@basf.com wrote: >> Hi Florian, >> >> Section 5.10: >> The variables are missing a "notify". It is: >> OCF_RESKEY_CRM_meta_notify_start_uname >> not >> OCF_RESKEY_CRM_meta_start_uname > > Thanks! Fixed. > http://people.linbit.com/~florian/ra-dev-guide/_literal_notify_literal_action.html > >> There is also the same set of variables that end on "_resource". > > I'll leave those out of now, as those have never been of any practical > relevance to me. If you're actually using them in an agent, please do > let me know. > >> Section 6.2: >> I think this statement: 'should never be changed by a resource agent ' >> is in >> conflict with Section 4.3. > > No it's not. 4.3 says you can override it _from the command line_, 6.2 > says the resource agent should not modify it. > >> Section 8.4: >> Statement: 'Stateful (master/slave) resources may influence their own >> /master preference'/ >> IMHO they _must_ influence thier own master preference. If not, >> they will never been promoted. > > Correct. Fixed. > http://people.linbit.com/~florian/ra-dev-guide/_specifying_a_master_preference.html > >> A "Note" that 'crm_mon -A' shows the current values, might be also >> very helpfull. > > Nope. I'll try to not talk about Pacemaker specific binaries too much. > >> No Section: >> Is there a reason, why the environment variable >> 'OCF_RESKEY_CRM_meta_role', which is set in the monitor action, >> isn't mentioned anywhere ? > > Make a good case for it to be explained, and convince me that it won't > just serve to confuse everybody, and I'll include it. My best guess, > however, is that once I do include it, we'll see a lot of > > monitor() { > if [ "$OCF_RESKEY_CRM_meta_role" = "Master" ]; then > return $OCF_RUNNING_MASTER > fi > ... > } > > ... and that's clearly nonsense.
And a good way to ensure i strip it from the environment :-) _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
