Just now found this thread. I will include the suggested changes and
post the new RA soon-ish.
Dominik
On 01/21/2011 08:26 AM, Florian Haas wrote:
> On 01/18/2011 04:21 PM, Florian Haas wrote:
>>> Our site will shortly be deploying a new HA firewall based on Linux,
>>> iptables, pacemaker and conntrackd.
>>> conntrackd[1] is used to maintain connection state of active
>>> connections
>>> across the two firewalls allowing us to failover from one firewall to
>>> the other without dropping any connections.
>>>
>>> In order to achieve this with pacemaker we needed to find a resource
>>> agent for conntrackd. Looking at the mailing list we found a couple of
>>> options although we only fully evaluated the RA produced by Dominik
>>> Klein as it appears to be more feature complete than the alternative.
>>> For a full description of his RA please see his original thread[2].
>>>
>>> So far throughout testing we have been very pleased with it. We can
>>> successfully fail between our nodes and the RA correctly handles the
>>> synchronisation steps required in the background.
>
> Dominik,
>
> it appears that the RA is good to be merged with just a few changes left
> to be done.
>
> * Please fix the initialization to honor $OCF_FUNCTIONS_DIR and ditch
> the redundant locale initialization.
>
> * Please rename the parameters to follow the precendents set by other
> RAs ("binary" instead of "conntrackd", "config" instead of
> "conntrackdconf").
>
> * Please don't require people to set a full path to the conntrackd
> binary, honoring $PATH is expected.
>
> * Please set defaults the way the other RAs do, rather than with your
> "if [ -z "OCF_RESKEY_whatever" ]" logic.
>
> * Please define the default path to your statefile in relative to
> ${HA_RSCTMP}. Also, put ${OCF_RESOURCE_INSTANCE} in the filename.
>
> * Actually, rather than managing your statefile manually, you might be
> able to just use ha_pseudo_resource().
>
> * Please revise your timeouts. Is a 240-second minimum timeout on start
> not a bit excessive?
>
> * Please revise your metadata, specifically your longdescs. The more
> useful information you provide to users, the better. Recall that that
> information is readily available to users via the man pages and "crm ra
> info".
>
> Thanks!
> Cheers,
> Florian
>
>
--
IN-telegence GmbH
Oskar-Jäger-Str. 125
50825 Köln
Registergericht AG Köln - HRB 34038
USt-ID DE210882245
Geschäftsführende Gesellschafter: Christian Plätke und Holger Jansen
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
