Hi Raoul, Thank you for comment.
> i think we could safely do the "kill -s 0" for *any* > version and call "postfix status" only if available. I think so. However, I do not know a lot about postfix so. I want the opinion of the detailed person. > btw. quickly looking at your patch, i spotted 1 > typo: "status_suuport" instead of "status_support" > (douple u/p) Sorry... It is my typo. > for the version check, i think we should try using the > ocf internal function. Ok. > > > * Change of the parameter check > the checks are basically fine. i would slightly update the > logging information. (i can do this when i apply your patches) Thanks! > > > * Error log when status processing failed > > * Value set of the ret variable > > i don't think that the use of $ret is correct. I made modifications to set unsettled ret variable in an original resource agent. But I am unsettled, the ret variable may not have to output it in log. Best Regards, Hideo Yamauchi. --- On Mon, 2011/6/6, Raoul Bhatia [IPAX] <r.bha...@ipax.at> wrote: > Hi Hideo-san! > > On 06/06/2011 04:51 AM, renayama19661...@ybb.ne.jp wrote: > > Hi All, > > > > I send a patch in conjunction with the status processing. > > It is made the following modifications. > > > > * Carry out status processing in a version judgment > > i think we could safely do the "kill -s 0" for *any* > version and call "postfix status" only if available. > > btw. quickly looking at your patch, i spotted 1 > typo: "status_suuport" instead of "status_support" > (douple u/p) > > for the version check, i think we should try using the > ocf internal function. > > > * Change of the parameter check > the checks are basically fine. i would slightly update the > logging information. (i can do this when i apply your patches) > > > * Error log when status processing failed > > * Value set of the ret variable > > i don't think that the use of $ret is correct. > > please comment on my suggestions and/or update the > ra in this regard. > > thanks, > raoul > -- > ____________________________________________________________________ > DI (FH) Raoul Bhatia M.Sc. email. r.bha...@ipax.at > Technischer Leiter > > IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at > Barawitzkagasse 10/2/2/11 email. off...@ipax.at > 1190 Wien tel. +43 1 3670030 > FN 277995t HG Wien fax. +43 1 3670030 15 > ____________________________________________________________________ > _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
