Hi,
I make a former patch again for agent3.9.2 and contribute it.
The patch performed the check of the portals parameter before setting a default
value.
When users use tgt, warning log is not output by iSCSI target-RA when users do
not set portals parameter.
The log of the next noise is not output by a patch.
Jul 12 19:15:54 srv01 iSCSITarget[13839]: WARNING: Configuration parameter
"portals" is not supported by the iSCSI implementation and will be ignored.
Jul 12 19:16:04 srv01 iSCSITarget[13957]: WARNING: Configuration parameter
"portals" is not supported by the iSCSI implementation and will be ignored.
Jul 12 19:16:14 srv01 iSCSITarget[14060]: WARNING: Configuration parameter
"portals" is not supported by the iSCSI implementation and will be ignored.
Jul 12 19:16:25 srv01 iSCSITarget[14189]: WARNING: Configuration parameter
"portals" is not supported by the iSCSI implementation and will be ignored.
* The link of an old email becomes next
* http://www.gossamer-threads.com/lists/linuxha/dev/70274
Please please confirm the contents of the patch.
Best Regards,
Hideo Yamauchi.
diff -r f4df06073f4d iSCSITarget
--- a/iSCSITarget Tue Jul 12 19:37:14 2011 +0900
+++ b/iSCSITarget Tue Jul 12 19:37:40 2011 +0900
@@ -42,9 +42,6 @@
fi
: ${OCF_RESKEY_implementation=${OCF_RESKEY_implementation_default}}
-# Listen on 0.0.0.0:3260 by default
-OCF_RESKEY_portals_default="0.0.0.0:3260"
-: ${OCF_RESKEY_portals=${OCF_RESKEY_portals_default}}
# Lockfile, used for selecting a target ID
LOCKFILE=${HA_RSCTMP}/iSCSITarget-${OCF_RESKEY_implementation}.lock
@@ -552,6 +549,7 @@
case $1 in
meta-data)
+ OCF_RESKEY_portals_default="0.0.0.0:3260"
meta_data
exit $OCF_SUCCESS
;;
@@ -564,6 +562,10 @@
# Everything except usage and meta-data must pass the validate test
iSCSITarget_validate
+# Listen on 0.0.0.0:3260 by default
+OCF_RESKEY_portals_default="0.0.0.0:3260"
+: ${OCF_RESKEY_portals=${OCF_RESKEY_portals_default}}
+
case $__OCF_ACTION in
start) iSCSITarget_start;;
stop) iSCSITarget_stop;;
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
