Hi Raoul,

> thanks for testing my ra. i'll check the ra and will then issue a
> pull request.

Okay.
We hope that a correction is included in the next release of the resource agent.

> 
> > However, my patch made a mistake.
> > I do not seem to get the result of postfix status.
> > It is necessary to watch log of postfix in the details of the problem after 
> > all.
> >
> > Therefore, I withdraw the patch of the part of postfix status.
> >
> > diff -r 19c97e0021f0 postfix
> > --- a/postfix   Thu Jun 16 21:45:53 2011 +0900
> > +++ b/postfix   Thu Jun 16 21:46:01 2011 +0900
> > @@ -98,12 +98,8 @@
> >   postfix_running() {
> >       # run Postfix status if available
> >       if ocf_is_true $status_support; then
> > -        output=`$binary $OPTION_CONFIG_DIR status 2>&1`
> > -        ret=$?
> > -        if [ $ret -ne 0 ]; then
> > -            ocf_log err "Postfix status: '$output'." $ret
> > -        fi
> > -        return $ret
> > +        $binary $OPTION_CONFIG_DIR status 2>&1
> > +        return $?
> >       fi
> >
> >       # manually check Postfix's pid
> 
> it's been a while since i looked into the code.
> 
> why do you want to issue "postfix status" if /usr/sbin/postfix
> does not support this command?

I thought that output could acquire the details of the problem of "postfix 
status" with a former patch.
And I thought the output of the details of the problem to be useful for an 
operator.
However, the details of the problem only were really reflected on log of 
postfix in the environment that I tried.

Therefore I want to withdraw the suggestion of the patch of this part.

Best Regards,
Hideo Yamauchi.

--- On Wed, 2011/9/7, Raoul Bhatia [IPAX] <r.bha...@ipax.at> wrote:

> On 06/16/2011 05:48 AM, renayama19661...@ybb.ne.jp wrote:
> > The postfix ra worked well.
> 
> thanks for testing my ra. i'll check the ra and will then issue a
> pull request.
> 
> > However, my patch made a mistake.
> > I do not seem to get the result of postfix status.
> > It is necessary to watch log of postfix in the details of the problem after 
> > all.
> >
> > Therefore, I withdraw the patch of the part of postfix status.
> >
> > diff -r 19c97e0021f0 postfix
> > --- a/postfix   Thu Jun 16 21:45:53 2011 +0900
> > +++ b/postfix   Thu Jun 16 21:46:01 2011 +0900
> > @@ -98,12 +98,8 @@
> >   postfix_running() {
> >       # run Postfix status if available
> >       if ocf_is_true $status_support; then
> > -        output=`$binary $OPTION_CONFIG_DIR status 2>&1`
> > -        ret=$?
> > -        if [ $ret -ne 0 ]; then
> > -            ocf_log err "Postfix status: '$output'." $ret
> > -        fi
> > -        return $ret
> > +        $binary $OPTION_CONFIG_DIR status 2>&1
> > +        return $?
> >       fi
> >
> >       # manually check Postfix's pid
> 
> it's been a while since i looked into the code.
> 
> why do you want to issue "postfix status" if /usr/sbin/postfix
> does not support this command?
> 
> thanks,
> raoul
> 
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to