On Mon, Sep 19, 2011 at 9:33 AM, Dejan Muhamedagic <de...@suse.de> wrote:
> On Mon, Sep 19, 2011 at 04:10:50PM +0200, Dejan Muhamedagic wrote:
> > On Tue, Sep 06, 2011 at 02:52:47PM -0600, Serge Dubrouski wrote:
> > > On Thu, Sep 1, 2011 at 6:28 AM, Dejan Muhamedagic <de...@suse.de>
> wrote:
> > >
> > [...]
> > > > > <parameter name="monitor_ip" unique="0" required="0">
> > > > > <longdesc lang="en">
> > > > > IP Address where named listens.
> > > > > </longdesc>
> > > > > <shortdesc lang="en">monitor_ip</shortdesc>
> > > > > <content type="string" default="${OCF_RESKEY_monitor_ip_default}"
> />
> > > > > </parameter>
> > > > > </parameters>
> > > >
> > > > Why not just use localhost? Could there be an instance which
> > > > doesn't listen on the lo interface?
> > > >
> > >
> > > Disagree. I usually prefer monitor clustered resources through VIPs
> they
> > > assigned to. Also localhost wouldn't work with the case of several
> instances
> > > listening on different interfaces.
> >
> > OK.
> >
> > [...]
> > > > > if [ -z "$OCF_RESKEY_monitor_request" -o \
> > > > > -z "$OCF_RESKEY_monitor_response" -o \
> > > > > -z "$OCF_RESKEY_monitor_ip" ]; then
> > > > > ocf_log err "Neither monitor_request, monitor_response or
> > > > monitor_ip can be empty"
> > > >
> > > > ocf_log err "Neither monitor_request, monitor_response, nor
> monitor_ip can
> > > > be empty"
> > > >
> > > > (I guess, not a native speaker.)
> > > >
> > >
> > > Even after 10 years of living in the US. Next time will check with my
> > > daughter ;-)
> >
> > Actually, I was wrong too. "Neither" can be used just for two
> > things, not three or more. In this case, it should be:
> >
> > ocf_log err "None of monitor_request, monitor_response, and monitor_ip
> can
> > be empty"
> >
> > I'll fix that before check-in.
>
> OT:
>
> Well, it turns out that I wasn't so wrong after all, just need
> to remove the comma:
>
> ocf_log err "Neither monitor_request, monitor_response nor monitor_ip can
> be empty"
>
> But the "None" variety still sounds better to me.
>
> Cheers,
>
Thanks.
>
> Dejan
>
> > Many thanks for the contribution!
> >
> > Cheers,
> >
> > Dejan
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
--
Serge Dubrouski.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
