Hi Hideo-san! On 2011-11-21 03:07, renayama19661...@ybb.ne.jp wrote: > It is judged that postfix works definitely and stops. > > The version that I confirmed is 2.6.6 on RHEL6.1. > > There seems to be a mistake with one patch. > The "postfix status" command does not seem to return a detailed result. > This is the same as "postfix check "command. > > I think that next is more right. > * I abolished output and omitted output from log. > > (snip) > postfix_running() { > local loglevel > loglevel=${1:-err} > > # run Postfix status if available > if ocf_is_true $status_support; then > $binary $OPTION_CONFIG_DIR status 2>&1 > ret=$? > if [ $ret -ne 0 ]; then > ocf_log $loglevel "Postfix status:" $ret > fi > return $ret > fi > (snip)
i applied this change and also updated the other of ocf_log lines a little bit: https://github.com/raoulbhatia/resource-agents/commit/4a5afaa217 i would like to resolve another issue though: if we expect to log an error, e.g.: 1. postfix stop 2. call postfix_running to see if postfix actually stopped. so there is an expected error if postfix_running which will get logged and will possibly trouble the admin, right? thinking about how to solve this for the postfix ra (e.g. using a "-q" parameter) i thought about using the ocf_run function. but the ocf_run function will log an error too... so i'll leave this issue until my other email is answered ;) cheers, raoul -- ____________________________________________________________________ DI (FH) Raoul Bhatia M.Sc. email. r.bha...@ipax.at Technischer Leiter IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at Barawitzkagasse 10/2/2/11 email. off...@ipax.at 1190 Wien tel. +43 1 3670030 FN 277995t HG Wien fax. +43 1 3670030 15 ____________________________________________________________________ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/