Hi Raoul,

Thank you for your comments!

> this method should leave the slave be if the master did not change
> since the last sync. consider:
>   crm node standby node02; crm node online node02
>
> the slave should pick up where it left using mysql's own way of saving
> the last replication information to master.info.
>
> so this must somehow be adapted too right?

Yes, I  got the same situation. :(

> here the ra tries to restore the master information from the cib.
> (this information is put there via unset_master(), see below )
>
> i think this part has to be moved up so that the outlined issues can be
> handled.
>
> moreover, setting the variable master_host might influence how the
> script works outside of the method (master_host is a global variable,
> if i'm not mistaken)

Yes, due to my carelessness, master_host is a global variable, so we
should change its name.

> consider this code:
>> unset_master(){
> in our case, this would save node01-mysqlrepl into the cib, right?

I see, I didn't consider information about CIB.

> this is the first shot at trying out the proposed patches.
> maybe it is sufficient to
>
> a) restructure set_master() a little bit and
> b) to modify get_slave_info() to strip the replication suffix from
>   the running config?

You are right.
I will revise the patch.

Thanks,
Junko
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to