Hi Dejan Thank you for an applied.
Regards, Tomo 2012年1月14日2:49 Dejan Muhamedagic <de...@suse.de>: > Hi, > > On Wed, Jan 11, 2012 at 11:07:59AM +0900, nozawat wrote: >> Hi Dejan >> >> Thank you for your comments. >> I revise an indication point and send it again. > > Applied. Many thanks for the patches! > > Cheers, > > Dejan > >> Regards, >> Tomo >> >> 2012年1月10日5:40 Dejan Muhamedagic <de...@suse.de>: >> > Hi, >> > >> > On Wed, Dec 28, 2011 at 05:52:51PM +0900, nozawat wrote: >> >> Hi >> >> >> >> The patches of slapd are as follows. >> >> 1)slapd-001.patch >> >> ->I made modifications to output a value of result code. >> > >> > It is usually referred to as "exit code" not "result code". >> > >> >> 2)slapd-002.patch >> >> ->An error occurs at the time of a start by a timing. >> >> Therefore I made modifications to restrain the error at the time >> >> of the start. >> > >> > This patch introduces a lot of code repetition. Better something >> > like this: >> > >> > local err_option="-err" >> > [ -z "$1" ] && err_option="" >> > ocf_run -q $err_option ... >> > >> > And two ifs for ocf_log err further down can be reduced to >> > >> > if [ -z "$1" ] || [ -n "$1" -a $result -ne 1 ]; then >> > >> > Cheers, >> > >> > Dejan >> > >> >> Regards, >> >> Tomo >> > >> > >> > >> >> _______________________________________________________ >> >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org >> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >> >> Home Page: http://linux-ha.org/ >> > >> > _______________________________________________________ >> > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org >> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >> > Home Page: http://linux-ha.org/ > > > >> _______________________________________________________ >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >> Home Page: http://linux-ha.org/ > > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/