On Sat, Feb 25, 2012 at 10:02 AM, Rasto Levrinc <rasto.levr...@gmail.com> wrote: > Hi, > > There are couple of issues in iSCSITarget meta-data. > > 1. there is a extra space in name attribute in status action and it > causes all sort of problems: > > <action name="status " <-- > > what it does, is that crm shell doesn't understand "status " action only > "status", but cib doesn't accept "status". So I can't simply fix it in > the GUI.
Fixed in the metadata: https://github.com/ClusterLabs/resource-agents/commit/ebb5e5d103066cb19b46427ef0f28937f4943dbe However, iirc RAs expose "status" operation only for age-old compatibility reasons, and Pacemaker only ever uses "monitor". Which is why, I guess, no-one has run into this problem before. Any reason for LCMC to use "status" at all? > And some not very critical... > > 2. short descriptions are not really short, I think it's not necessary > prepend every one of them with "iSCSI target" > > The worst offender > <shortdesc lang="en">Manages an iSCSI target export</shortdesc> > > could be changed to "Implementation", or "Daemon Implementation" to be > short and descriptive. Yeah, that one was just a copy & paste error. Fixed too, thanks. About the others, I can only surmise you're bikeshedding -- those look fine to me. However, I'll be happy to take a patch if you have better suggestions. > 3. defaults are computed in this way that they may be different in > different cluster nodes and may change after the cluster is configured, > which is not very useful in my opinion. That was my way of trying to provide a "reasonable" default across distros. The alternative would be that every distro packager would have to patch the RA to provide the proper default for their platform -- which would be tgt for RHEL/CentOS, iet for SLES 11 and then lio for SLES 11 SP2+ (I think), undefined for Debian. You get the picture. I think the existing way of figuring out the defaults is saner, if not perfect. Feel free to convince me otherwise, though. Cheers, Florian -- Need help with High Availability? http://www.hastexo.com/now _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
