On Feb 12, 2008, at 1:02 AM, Johan Hoeke wrote:

Johan Hoeke wrote:
Johan Hoeke wrote:

OK, found out that 2.1.3 will start on my i386 systems if I disable
hbaping. I'll recompile the hbaping stuff for 2.1.3. That will probably
work.


hmmm, not my lucky day:

[EMAIL PROTECTED] heartbeat-2.1.3-3]# rpmbuild --rebuild
heartbeat-2.1.3-3.el4.centos.src.rpm

...
<snip>
...

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I. -I../../../include
-I../../../include -I../../../include -I../../../include
-I../../../linux-ha -I../../../linux-ha -I../../../libltdl
-I../../../libltdl -I../../../lib/upmls -I../../../lib/upmls
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/libxml2 -g -O2 -Wall -Wmissing-prototypes
-Wmissing-declarations -Wstrict-prototypes -Wdeclaration-after- statement
-Wpointer-arith -Wwrite-strings -Wcast-qual -Wcast-align
-Wbad-function-cast -Winline -Wmissing-format-attribute -Wformat=2
-Wformat-security -Wformat-nonliteral -Wno-long-long
-Wno-strict-aliasing -Werror -ggdb3 -funsigned-char -g -O2 -Wall
-Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes
-Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings
-Wcast-qual -Wcast-align -Wbad-function-cast -Winline
-Wmissing-format-attribute -Wformat=2 -Wformat-security
-Wformat-nonliteral -Wno-long-long -Wno-strict-aliasing -Werror - ggdb3
-funsigned-char -MT hbaping.lo -MD -MP -MF .deps/hbaping.Tpo -c
hbaping.c  -fPIC -DPIC -o .libs/hbaping.o
hbaping.c: In function `hbaping_new':
hbaping.c:241: warning: ISO C90 forbids mixed declarations and code



any advice on how to dodge this "ISO C90 forbids mixed declarations and
code" compile error?

thanks,

regards,

Johan

dubblechecked by doing a rpmbuild --rebuild for
heartbeat-2.1.2-3.el4.centos.src.rpm on the same i386 server. It build
just fine.

Strange, it should break consistently. Anyway, I'll commit the following patch shortly

diff -r 405a47c90e21 lib/plugins/HBcomm/hbaping.c
--- a/lib/plugins/HBcomm/hbaping.c      Mon Feb 11 11:39:48 2008 +0100
+++ b/lib/plugins/HBcomm/hbaping.c      Tue Feb 12 09:06:35 2008 +0100
@@ -237,8 +237,8 @@ hbaping_new(const char * host)

        ret = (struct hb_media *) MALLOC(sizeof(struct hb_media));
        if (ret != NULL) {
+               char * name;
                memset(ret, 0, sizeof(*ret));
-               char * name;
                ret->pd = (void*)ipi;
                name = MALLOC(strlen(host)+1);
                strcpy(name, host);


The rebuild of both heartbeat-2.1.3-2.el4.centos.src.rpm and
heartbeat-2.1.3-3.el4.centos.src.rpm break with the above error. Also,
the 2.1.3-* packages don't build on my x86_64 machines either. Strangely enough, the hbaping stuff Just Works there without recompiling anything.

Is the breaking of the rpmbuild --rebuild some kind of packaging problem?

all of these packages are from:
http://mirror.centos.org/centos/4/extras/SRPMS/

alternatively, try the packages at:
   http://download.opensuse.org/repositories/server:/ha-clustering/CentOS_5/




regards,

Johan

_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to