Hi, -----Original Message----- From: Dejan Muhamedagic [mailto:deja...@fastmail.fm] Sent: Thu 15/07/2010 15:47 To: General Linux-HA mailing list Subject: Re: [Linux-HA] Tomcat resource agent - PATCH2 - minor script fixes Hi,
On Mon, Jul 12, 2010 at 01:03:05PM +0100, Brett Delle Grazie wrote:
> Hi,
>
> Another patch for the Tomcat resource agent.
>
> This patch simply:
>
> 1. Removes the 'n' character added after the '\' on the export
> commands - otherwise this causes "'n' not found" messages to
> occur in the resource agent log during start and stop
> operations.
It'd be cleaner to feed everything on the stdin to the su command:
cat<<EOF | su - -s /bin/sh $RESOURCE_TOMCAT_USER >> "$TOMCAT_CONSOLE" 2>&1 &
export JAVA_HOME=${OCF_RESKEY_java_home}
...
$CATALINA_HOME/bin/catalina.sh start ${OCF_RESKEY_tomcat_start_opts}
EOF
If you feel like testing this too ...
BDG: What a good suggestion. Will test and resubmit.
> 2. Adds a missing background operator (&) to the stop
> operation. Otherwise the stop operation cannot be monitored by
> the resource agent
This is a different issue. I'll split it off.
BDG: Fine, no problem - its a trivial fix.
Thanks,
Dejan
> This patch can be applied independently of the documentation
> patch supplied previously.
>
> I hope this helps
>
Thanks,
Best Regards,
Brett
______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________<<winmail.dat>>
_______________________________________________ Linux-HA mailing list Linux-HA@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
