On Thu, Nov 18, 2010 at 4:06 PM, Matthew Richardson <m.richard...@ed.ac.uk> wrote: > I've been playing with the existing HealthSMART RA in Pacemaker and have > discovered a number of fundamental bugs and errors with it that mean it > will never have worked for anyone. > > I've done a big overhaul of this RA, replacing most of the logic to make > it work properly, and extending the component to cover a few more use-cases: > > - Handles lists of drives > - Handles 'devices' behind drives - useful for RAID devices e.g 3ware, > megaraid etc > - Threshold for 'yellow' is now configurable (relative to upper/lower > limits) > - Various bugfixes, typos, indentation etc > > I've attached the whole RA to thsi email, as its changed enough that a > diff would have just been unhelpful. > > I'm fairly sure that the logic behind the smartctl result handling is > correct, I'm pretty sure the shell is all valid, but as I've been > working with an existing 'template' I can't guarantee that the > ocf-related bits are valid, as this is the area I know least about. > > I've tested it as much as I can, but I'd be grateful if other people > could review the code/test the RA and let me know if there are any > obvious bugs, errors or 'just plain bad code' in it :)
Looks like a nice set of improvements. Many thanks for the new version! > > Thanks, > > Matthew > > > -- > The University of Edinburgh is a charitable body, registered in > Scotland, with registration number SC005336. > > _______________________________________________ > Linux-HA mailing list > Linux-HA@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha > See also: http://linux-ha.org/ReportingProblems > _______________________________________________ Linux-HA mailing list Linux-HA@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
