On 2011-11-12 03:14, Russell Bryant wrote: >> https://github.com/fghaas/resource-agents/commit/ac34c61cc209c389c4501a9f4a699a23e803a0f6#heartbeat/asterisk >> >> Does this look reasonable to you? >> >> In case you're unfamiliar with our function library: ocf_run runs a >> command and captures its output, but only writes the output to the logs >> if the command returned an error. > > Cool, that wasn't so bad. :-)
You mean in terms of amount of code required to add this? No, that one's not a biggie. > Looks good to me. > > On a related note, looks like sipsak is broken in Fedora so I'll have > to file a bug on that. > > $ sipsak -v -s sip:[email protected] > Segmentation fault > > I tried it on another system and it worked fine, though. OK. I guess we'll give this another whirl in our test environment, and then add a final whitespace cleanup patch. After that, barring any vetoes from Lars and/or Dejan, I think this one is good to merge. Cheers, Florian -- Need help with High Availability? http://www.hastexo.com/now _______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
