On Tue, Dec 12, 2023 at 10:40:03AM -0600, Ninad Palsule wrote: > From: Joel Stanley <[email protected]> > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > Add a compatible string for it, and the generic compatible. > > OpenBMC-Staging-Count: 3
Delete this from every patch that it appears from. > Signed-off-by: Joel Stanley <[email protected]> > Acked-by: Jarkko Sakkinen <[email protected]> > Link: https://lore.kernel.org/r/[email protected] > Signed-off-by: Ninad Palsule <[email protected]> > --- > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > index a897402cc36a..9511c0d50185 100644 > --- a/drivers/char/tpm/tpm_tis_i2c.c > +++ b/drivers/char/tpm/tpm_tis_i2c.c > @@ -383,6 +383,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > #ifdef CONFIG_OF > static const struct of_device_id of_tis_i2c_match[] = { > { .compatible = "infineon,slb9673", }, > + { .compatible = "nuvoton,npct75x", }, > + { .compatible = "tcg,tpm-tis-i2c", }, What's the point of the generic compatible if you are adding the device specific ones to the driver anyway? Thanks, Conor. > {} > }; > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > -- > 2.39.2 >
signature.asc
Description: PGP signature
