Hi Bartosz, On Fri, 7 Feb 2025 at 09:02, Bartosz Golaszewski <[email protected]> wrote: > On Mon, Feb 3, 2025 at 1:18 PM Andy Shevchenko > <[email protected]> wrote: > > > > Remove unneeded dependency to OF_GPIO which driver does not use. > > > > Fixes: 3c7469514dbe ("gpio: 74x164: Make use of device properties") > > Signed-off-by: Andy Shevchenko <[email protected]> > > --- > > drivers/gpio/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > > index add5ad29a673..56c1f30ac195 100644 > > --- a/drivers/gpio/Kconfig > > +++ b/drivers/gpio/Kconfig > > @@ -1790,7 +1790,6 @@ menu "SPI GPIO expanders" > > > > config GPIO_74X164 > > tristate "74x164 serial-in/parallel-out 8-bits shift register" > > - depends on OF_GPIO > > help > > Driver for 74x164 compatible serial-in/parallel-out 8-outputs > > shift registers. This driver can be used to provide access
> > Geert: Just Cc'ing you here because you yelled at me last time I > removed all dependencies. This driver is under the SPI section so it > does have the CONFIG_SPI_MASTER dependency. I think it's fine to drop > OF_GPIO here but I just wanted to run it by you. That's fine, as there is still the SPI_MASTER dependency, and the driver uses device properties. Reviewed-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
