On Sat, 15 Mar 2025, Alejandro Colomar wrote: > > > GCC 15's -Wunterminated-string-initialization warned about truncated > > > name strings. Instead of marking them with the "nonstring" attribute[1], > > > increase their length to correctly include enough space for the > > > terminating NUL character, as they are used with %s format specifiers. > > It might be interesting to mention where they are used with %s.
Indeed. I seem to be missing something here as I can't see an issue in reality: # cat /proc/ioports | sed -n '/EISA/,$p' 0c80-0c83 : 486EI EISA System Board 5000-50ff : DEC FDDIcontroller/EISA Adapter 5000-503f : defxx 5040-5043 : defxx 5400-54ff : DEC FDDIcontroller/EISA Adapter 5800-58ff : DEC FDDIcontroller/EISA Adapter 5c00-5cff : DEC FDDIcontroller/EISA Adapter 5c80-5cbf : defxx 6000-60ff : Network Peripherals NP-EISA-3E Enhanced FDDI Inte 6400-64ff : Network Peripherals NP-EISA-3E Enhanced FDDI Inte 6800-68ff : Network Peripherals NP-EISA-3E Enhanced FDDI Inte 6c00-6cff : Network Peripherals NP-EISA-3E Enhanced FDDI Inte 8000-80ff : 3Com 3C509-Combo Network Adapter 8000-800f : 3c579-eisa 8400-84ff : 3Com 3C509-Combo Network Adapter 8800-88ff : 3Com 3C509-Combo Network Adapter 8c00-8cff : 3Com 3C509-Combo Network Adapter # nor why incrementing the length specifically to 51 (where eisa.ids names are up to 73 characters; one of the longer entries can be seen truncated above) is going to change anything here. Overall since the string length is fixed I'd expect just using `%.50s' instead. > > For what it's worth, it looks fine to me. > > LGTM too. Assuming that changing the size of the arrays doesn't break > something else, it looks good. ISTM increasing to 74 instead might make more sense (I don't know what the actual maximum size was according to the ECU standard, but it might not be that we'll ever add any new entries to our list), once the origin of the problem is known, though I think we need to evaluate what effect such a change will have on the size of the compiled kernel. Maciej
