Provide ASIC ID, ASIC revision, firmware version and optionally
custom config version through devlink device info.

Sample output:
 # devlink dev
 i2c/1-0070
 # devlink dev info
 i2c/1-0070:
   driver zl3073x-i2c
   versions:
       fixed:
         asic.id 1E94
         asic.rev 300
         fw 7006

Reviewed-by: Michal Schmidt <[email protected]>
Signed-off-by: Ivan Vecera <[email protected]>
---
 drivers/mfd/zl3073x-core.c | 73 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c
index b3091b00cffa8..33e76666e5694 100644
--- a/drivers/mfd/zl3073x-core.c
+++ b/drivers/mfd/zl3073x-core.c
@@ -142,7 +142,80 @@ int zl3073x_write_reg(struct zl3073x_dev *zldev, unsigned 
int reg,
 }
 EXPORT_SYMBOL_GPL(zl3073x_write_reg);
 
+/**
+ * zl3073x_devlink_info_get - Devlink device info callback
+ * @devlink: devlink structure pointer
+ * @req: devlink request pointer to store information
+ * @extack: netlink extack pointer to report errors
+ *
+ * Returns 0 in case of success or negative value otherwise
+ */
+static int zl3073x_devlink_info_get(struct devlink *devlink,
+                                   struct devlink_info_req *req,
+                                   struct netlink_ext_ack *extack)
+{
+       struct zl3073x_dev *zldev = devlink_priv(devlink);
+       u16 id, revision, fw_ver;
+       char buf[16];
+       u32 cfg_ver;
+       int rc;
+
+       guard(zl3073x)(zldev);
+
+       rc = zl3073x_read_id(zldev, &id);
+       if (rc)
+               return rc;
+
+       snprintf(buf, sizeof(buf), "%X", id);
+       rc = devlink_info_version_fixed_put(req,
+                                       DEVLINK_INFO_VERSION_GENERIC_ASIC_ID,
+                                       buf);
+       if (rc)
+               return rc;
+
+       rc = zl3073x_read_revision(zldev, &revision);
+       if (rc)
+               return rc;
+
+       snprintf(buf, sizeof(buf), "%X", revision);
+       rc = devlink_info_version_fixed_put(req,
+                                       DEVLINK_INFO_VERSION_GENERIC_ASIC_REV,
+                                       buf);
+       if (rc)
+               return rc;
+
+       rc = zl3073x_read_fw_ver(zldev, &fw_ver);
+       if (rc)
+               return rc;
+
+       snprintf(buf, sizeof(buf), "%u", fw_ver);
+       rc = devlink_info_version_fixed_put(req,
+                                           DEVLINK_INFO_VERSION_GENERIC_FW,
+                                           buf);
+       if (rc)
+               return rc;
+
+       rc = zl3073x_read_custom_config_ver(zldev, &cfg_ver);
+       if (rc)
+               return rc;
+
+       /* No custom config version */
+       if (cfg_ver == U32_MAX)
+               return rc;
+
+       snprintf(buf, sizeof(buf), "%lu.%lu.%lu.%lu",
+                FIELD_GET(GENMASK(31, 24), cfg_ver),
+                FIELD_GET(GENMASK(23, 16), cfg_ver),
+                FIELD_GET(GENMASK(15, 8), cfg_ver),
+                FIELD_GET(GENMASK(7, 0), cfg_ver));
+
+       rc = devlink_info_version_running_put(req, "cfg.custom_ver", buf);
+
+       return rc;
+}
+
 static const struct devlink_ops zl3073x_devlink_ops = {
+       .info_get = zl3073x_devlink_info_get,
 };
 
 static void zl3073x_devlink_free(void *ptr)
-- 
2.48.1


Reply via email to