On May 20, 2025 8:09:29 PM PDT, Jakub Kicinski <[email protected]> wrote:
>On Tue, 20 May 2025 17:42:32 -0700 Kees Cook wrote:
>> Ah yes, I can include that in the next version if you want? I was trying
>> to find a stopping point since everything kind of touches everything ...
>
>Looks like the build considers -Wincompatible-pointer-types to always
>imply -Werror or some such? We explicitly disable CONFIG_WERROR in our
>CI, but we still get:
>
>drivers/net/macvlan.c:1302:34: error: incompatible pointer types passing
>'struct sockaddr *' to parameter of type 'struct __kernel_sockaddr_storage *'
>[-Werror,-Wincompatible-pointer-types]
> 1302 | dev_set_mac_address(port->dev, &sa, NULL);
> | ^~~
>
>on this series :(
I'll get this fixed and add dev_set_mac_address_user() for v3...
--
Kees Cook
