On Tue, Jun 10, 2025 at 02:04:58PM +0900, Naoya Tezuka wrote: > On ChromiumOS devices, the ecc_size is set to 0 (check dmesg | grep ecc > to see `ecc: 0`): this disables ECC for ramoops region, even when > ramoops.ecc=1 is given to kernel command line parameter. > > This patch introduces ecc_size module parameter to provide an method to > turn on ECC for ramoops and set different values of ecc_size per devices.
The doc [1] suggests to describe changes in imperative mood. If you have chance to send next version, please fix it. Otherwise, it doesn't really bother me. [1]: https://docs.kernel.org/process/submitting-patches.html > @@ -9,6 +9,10 @@ > #include <linux/platform_device.h> > #include <linux/pstore_ram.h> > > +static int ecc_size; > +module_param(ecc_size, int, 0444); Does it need to be world-readable? How about 0400? > @@ -117,6 +121,9 @@ static int __init chromeos_pstore_init(void) > { > bool acpi_dev_found; > > + if (ecc_size > 0) > + chromeos_ramoops_data.ecc_info.ecc_size = ecc_size; It seems `ecc_size` doesn't have an upper bound. Wondering what would be happened if it is a somehow large value.
