On Tue, Jun 24, 2025 at 4:21 PM Brahmajit Das <[email protected]> wrote: > > strcpy() is deprecated; use sysfs_emit() instead. No functional changes > intended.
It may be deprecated, but is it used incorrectly in this particular case? > Link: https://github.com/KSPP/linux/issues/88 > Signed-off-by: Brahmajit Das <[email protected]> > --- > drivers/acpi/sysfs.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c > index a48ebbf768f9..7ce90998ab97 100644 > --- a/drivers/acpi/sysfs.c > +++ b/drivers/acpi/sysfs.c > @@ -181,10 +181,9 @@ static int param_set_trace_method_name(const char *val, > > /* This is a hack. We can't kmalloc in early boot. */ > if (is_abs_path) > - strcpy(trace_method_name, val); > + sysfs_emit(trace_method_name, "%s", val); > else { > - trace_method_name[0] = '\\'; > - strcpy(trace_method_name+1, val); > + sysfs_emit(trace_method_name, "\%s", val); > } The code does strlen() checks before this, I don't think that the change is an improvement. > > /* Restore the original tracer state */ > --
