On 08/10/2025 05:59, Kees Cook wrote: > The DRIVER_AUTHOR macro incorrectly included a semicolon in its > string literal definition. Right now, this wasn't causing any real > problem, but coming changes to the MODULE_INFO() macro make this more > sensitive. Specifically, when used with MODULE_AUTHOR(), this created > syntax errors during macro expansion: > > MODULE_AUTHOR(DRIVER_AUTHOR); > > expands to: > > MODULE_INFO(author, "Joonyoung Shim <[email protected]>";) > ^ > syntax error > > Remove the trailing semicolon from the DRIVER_AUTHOR definition. > Semicolons should only appear at the point of use, not in the macro > definition. > > Signed-off-by: Kees Cook <[email protected]>
Reviewed-by: Hans Verkuil <[email protected]> > --- > Cc: Hans Verkuil <[email protected]> > Cc: Mauro Carvalho Chehab <[email protected]> > Cc: Uwe Kleine-König <[email protected]> > Cc: <[email protected]> > --- > drivers/media/radio/si470x/radio-si470x-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c > b/drivers/media/radio/si470x/radio-si470x-i2c.c > index cdd2ac198f2c..3932a449a1b1 100644 > --- a/drivers/media/radio/si470x/radio-si470x-i2c.c > +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c > @@ -10,7 +10,7 @@ > > > /* driver definitions */ > -#define DRIVER_AUTHOR "Joonyoung Shim <[email protected]>"; > +#define DRIVER_AUTHOR "Joonyoung Shim <[email protected]>" > #define DRIVER_CARD "Silicon Labs Si470x FM Radio" > #define DRIVER_DESC "I2C radio driver for Si470x FM Radio Receivers" > #define DRIVER_VERSION "1.0.2"
