On Wed, Nov 12, 2025 at 07:47:25PM +0800, WangYuli wrote: > From: WangYuli <[email protected]> > > The test_fortify.sh script generates logs of build-time warnings > for string and memory functions. To ensure the final log file is > updated atomically, the script first writes its output to a temporary > file with a .log.tmp extension. Upon successful completion, this > temporary file is renamed to the final .log file. > > If the build process is interrupted before this rename operation, > these *.log.tmp intermediate files will be left in the directory, > creating a risk of them being accidentally added to the git repository.
Shouldn't the cleanup trap in lib/test_fortify/test_fortify.sh be enough to avoid leaving behind .log.tmp? Or does that only work for clean exits? Would adding INT to the trap avoid the problem? > To prevent this from happening, add *.tmp to the .gitignore file to > explicitly ignore these temporary files. > > Signed-off-by: WangYuli <[email protected]> > Signed-off-by: WangYuli <[email protected]> Regardless, this seems fine in the meantime. Reviewed-by: Nathan Chancellor <[email protected]> > --- > lib/test_fortify/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/test_fortify/.gitignore b/lib/test_fortify/.gitignore > index c1ba37d14b50..8056bc75b442 100644 > --- a/lib/test_fortify/.gitignore > +++ b/lib/test_fortify/.gitignore > @@ -1,2 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > /*.log > +/*.tmp > -- > 2.51.0 >
