> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Tuesday, October 24, 2017 12:48 PM
> To: Jean Delvare <jdelv...@suse.com>; Vadim Pasternak
> <vad...@mellanox.com>
> Cc: Guenter Roeck <li...@roeck-us.net>; linux-hwmon@vger.kernel.org;
> kernel-janit...@vger.kernel.org
> Subject: [PATCH] hwmon: (max6621) Inverted if condition in max6621_read()
>
> We intended to test for failure here but accidentally tested for success. It
> means that we don't set "*val" to true and it means that if
> i2c_smbus_write_byte() does fail then we return success.
>
> Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621
> temperature sensor")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Acked-by: Vadim Pasternak <vad...@mellanox.com>
>
> diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c index
> 22079ec29660..35555f0eefb9 100644
> --- a/drivers/hwmon/max6621.c
> +++ b/drivers/hwmon/max6621.c
> @@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum
> hwmon_sensor_types type, u32 attr,
> if (regval) {
> ret = i2c_smbus_write_byte(data->client,
>
> MAX6621_CLEAR_ALERT_REG);
> - if (!ret)
> + if (ret)
> return ret;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
