Hello Guenter, On Thu, Sep 12, 2019 at 11:32:18AM -0700, Guenter Roeck wrote: > On Wed, Sep 11, 2019 at 05:28:14PM -0700, Nicolin Chen wrote: > > Hello Guenter, > > > > Datasheet: http://www.ti.com/lit/ds/symlink/ina3221.pdf > > (At page 32, chapter 8.6.2.14 and 8.6.2.15) > > > > I have two registers that I need to expose to user space: > > Shunt-Voltage-Sum and Shunt-Voltage-Limit registers > > > > Right now in[123]_input of INA3221 are for voltage channels > > while in[456]_input are for Shunt voltage channels. > > > > So can I just use in7_input and in7_crit for them? > > > Doesn't Shunt-Voltage-Limit apply to in[456]_input ? > If so, the limit should be attached to those.
The initial patch of ina3221 driver applied Shunt-Voltage-Limits, being named as "Critical Alert Limit Registers" in the datasheet, to curr[123]_crit, corresponding to curr[123] and in[456]_input. And this Shunt-Voltage-Limit-Sum is more related to the reading from Shunt-Voltage-Sum, which we just agreed it to be in7_input. Do you mean that this Limit-Sum should become in[456]_crit even though it only has one value, related to sum of all three shunt voltage channels? > in7_input for Shunt-Voltage-Sum would be fine. Okay. Will add in7_input for Shunt-Voltage-Sum. Thanks!
