Hi Dmitry, I love your patch! Yet something to improve:
[auto build test ERROR on hwmon/hwmon-next] [cannot apply to v5.4-rc1 next-20191002] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/hwmon-applesmc-switch-to-using-input-device-polling-mode/20191003-063910 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/hwmon/applesmc.c: In function 'applesmc_create_accelerometer': >> drivers/hwmon/applesmc.c:1163:8: error: implicit declaration of function >> 'input_setup_polling'; did you mean 'input_set_capability'? >> [-Werror=implicit-function-declaration] ret = input_setup_polling(applesmc_idev, applesmc_idev_poll); ^~~~~~~~~~~~~~~~~~~ input_set_capability >> drivers/hwmon/applesmc.c:1167:2: error: implicit declaration of function >> 'input_set_poll_interval'; did you mean 'input_set_abs_params'? >> [-Werror=implicit-function-declaration] input_set_poll_interval(applesmc_idev, APPLESMC_POLL_INTERVAL); ^~~~~~~~~~~~~~~~~~~~~~~ input_set_abs_params cc1: some warnings being treated as errors vim +1163 drivers/hwmon/applesmc.c 1132 1133 /* Create accelerometer resources */ 1134 static int applesmc_create_accelerometer(void) 1135 { 1136 int ret; 1137 1138 if (!smcreg.has_accelerometer) 1139 return 0; 1140 1141 ret = applesmc_create_nodes(accelerometer_group, 1); 1142 if (ret) 1143 goto out; 1144 1145 applesmc_idev = input_allocate_device(); 1146 if (!applesmc_idev) { 1147 ret = -ENOMEM; 1148 goto out_sysfs; 1149 } 1150 1151 /* initial calibrate for the input device */ 1152 applesmc_calibrate(); 1153 1154 /* initialize the input device */ 1155 applesmc_idev->name = "applesmc"; 1156 applesmc_idev->id.bustype = BUS_HOST; 1157 applesmc_idev->dev.parent = &pdev->dev; 1158 input_set_abs_params(applesmc_idev, ABS_X, 1159 -256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT); 1160 input_set_abs_params(applesmc_idev, ABS_Y, 1161 -256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT); 1162 > 1163 ret = input_setup_polling(applesmc_idev, applesmc_idev_poll); 1164 if (ret) 1165 goto out_idev; 1166 > 1167 input_set_poll_interval(applesmc_idev, APPLESMC_POLL_INTERVAL); 1168 1169 ret = input_register_device(applesmc_idev); 1170 if (ret) 1171 goto out_idev; 1172 1173 return 0; 1174 1175 out_idev: 1176 input_free_device(applesmc_idev); 1177 1178 out_sysfs: 1179 applesmc_destroy_nodes(accelerometer_group); 1180 1181 out: 1182 pr_warn("driver init failed (ret=%d)!\n", ret); 1183 return ret; 1184 } 1185 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
