On Tue, 2019-10-08 at 13:11 -0700, Guenter Roeck wrote:
>
> On Tue, Oct 08, 2019 at 03:59:49PM +0000, Sa, Nuno wrote:
> [ ... ]
> > > > +
> > > > + ctl->irq = platform_get_irq(pdev, 0);
> > > > + if (ctl->irq < 0) {
> > >
> > > This can return -EPROBE_DEFER. On top of that, it already
> > > generates
> > > an error
> > > message, meaning another one here is unnecessary.
> >
> > Why returning -EPROBE_DEFER? platform_get_irq() already seems to
> > handle
> > EPROBE_DEFER...
> >
> ... which is exactly why I am saying that you don't need another
> error
> message, and that an unconditional error message is a bad idea.
>
Ahhh, sorry. I completely misunderstood you :(
Nuno Sá
> Guenter
