> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Friday, May 16, 2025 9:05 PM
> To: Haiyang Zhang <[email protected]>
> Cc: [email protected]; [email protected]; Dexuan Cui
> <[email protected]>; [email protected]; KY Srinivasan
> <[email protected]>; Paul Rosswurm <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Long Li <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Konstantin
> Taranov <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: [EXTERNAL] Re: [PATCH net-next,v4] net: mana: Add handler for
> hardware servicing events
>
> On Wed, 14 May 2025 13:30:37 -0700 Haiyang Zhang wrote:
> > + dev_info(gc->dev, "Start MANA service type:%d\n", type);
> > + gc->in_service = true;
> > + mns_wk->pdev = to_pci_dev(gc->dev);
> > + INIT_WORK(&mns_wk->serv_work, mana_serv_func);
> > + schedule_work(&mns_wk->serv_work);
>
> I don't see any refcounting in this patch, and the work is not
> canceled. What if the device is removed between work being scheduled
> and running?
Thanks for the review. I added refcnt handling, and submitted a new
patch.
- Haiyang
