On Mon, Jun 30, 2025 at 08:55:25PM +0200, Rafael J. Wysocki wrote: > s/a helper/helper/ in the subject.
Ugh! I missed this since v3. I corrected it. Thanks for noticing. > > On Sat, Jun 28, 2025 at 5:35 AM Ricardo Neri > <[email protected]> wrote: > > > > In preparation to move the functionality to wake secondary CPUs up out of > > the ACPI code, add two helper functions. > > > > The function acpi_setup_mp_wakeup_mailbox() stores the physical address of > > the mailbox and updates the wakeup_secondary_cpu_64() APIC callback. > > > > There is a slight change in behavior: now the APIC callback is updated > > before configuring CPU hotplug offline behavior. This is fine as the APIC > > callback continues to be updated unconditionally, regardless of the > > restriction on CPU offlining. > > > > The function acpi_madt_multiproc_wakeup_mailbox() returns a pointer to the > > mailbox. Use this helper function only in the portions of the code for > > which the variable acpi_mp_wake_mailbox will be out of scope once it is > > relocated out of the ACPI directory. > > > > The wakeup mailbox is only supported for CONFIG_X86_64 and needed only with > > CONFIG_SMP=y. > > > > Signed-off-by: Ricardo Neri <[email protected]> > > With the above nit addressed > > Acked-by: Rafael J. Wysocki <[email protected]> Thank you!
