> -----Original Message-----
> From: Simon Horman <[email protected]>
> Sent: Friday, September 12, 2025 8:29 AM
> To: Haiyang Zhang <[email protected]>
> Cc: [email protected]; [email protected]; Haiyang Zhang
> <[email protected]>; Dexuan Cui <[email protected]>; KY Srinivasan
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Long Li
> <[email protected]>; [email protected];
> [email protected]; [email protected]; Konstantin
> Taranov <[email protected]>; Shiraz Saleem
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: [EXTERNAL] Re: [PATCH net-next] net: mana: Reduce waiting time if
> HWC not responding
>
> On Wed, Sep 10, 2025 at 01:57:21PM -0700, Haiyang Zhang wrote:
> > From: Haiyang Zhang <[email protected]>
> >
> > If HW Channel (HWC) is not responding, reduce the waiting time, so
> further
> > steps will fail quickly.
> > This will prevent getting stuck for a long time (30 minutes or more),
> for
> > example, during unloading while HWC is not responding.
> >
> > Signed-off-by: Haiyang Zhang <[email protected]>
> > ---
> > drivers/net/ethernet/microsoft/mana/hw_channel.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > index ef072e24c46d..ada6c78a2bef 100644
> > --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > @@ -881,7 +881,12 @@ int mana_hwc_send_request(struct hw_channel_context
> *hwc, u32 req_len,
> > if (!wait_for_completion_timeout(&ctx->comp_event,
> > (msecs_to_jiffies(hwc->hwc_timeout))))
> > {
> > if (hwc->hwc_timeout != 0)
> > - dev_err(hwc->dev, "HWC: Request timed out!\n");
> > + dev_err(hwc->dev, "HWC: Request timed out: %u ms\n",
> > + hwc->hwc_timeout);
> > +
> > + /* Reduce further waiting if HWC no response */
> > + if (hwc->hwc_timeout > 1)
> > + hwc->hwc_timeout = 1;
>
> Hi,
>
> Perhaps it is already the case, but I'm wondering if the configured
> value of hwc_timeout should be restored at some point.
Yes it's already the case: when the driver does reset/recovery, or gets
a timeout-value-message from the NIC, the time out value will be updated.
Thanks,
- Haiyang
