On 9/19/25 02:06, Borislav Petkov wrote: > On Thu, Sep 18, 2025 at 11:52:35PM +0000, Michael Kelley wrote: >> From: Mukesh R <[email protected]> Sent: Tuesday, September 16, >> 2025 2:31 PM >>> >>> On 9/15/25 10:55, Michael Kelley wrote: >>>> From: Mukesh Rathor <[email protected]> Sent: Tuesday, September >>>> 9, 2025 5:10 PM >>>>> >>>>> Introduce a small asm stub to transition from the hypervisor to linux >>>> >>>> I'd argue for capitalizing "Linux" here and in other places in commit >>>> text and code comments throughout this patch set. >>> >>> I'd argue against it. A quick grep indicates it is a common practice, >>> and in the code world goes easy on the eyes :). > > But not in commit messages. > > Commit messages should be maximally readable and things should start in > capital letters if that is their common spelling. > > When it comes to "Linux", yeah, that's so widespread so you have both. If I'm > referring to what Linux does as a policy or in general or so on, I'd spell it > capitalized but I don't think we've enforced that too strictly... > >> I'll offer a final comment on this topic, and then let it be. There's >> a history of Greg K-H, Marc Zyngier, Boris Petkov, Sean Christopherson, >> and other maintainers giving comments to use the capitalized form >> of "Linux", "MSR", "RAM", etc. See: > > MSR, RAM and other abbreviations are capitalized and that's the only correct > way to spell them. > >>>>> upon devirtualization. > > What is "devirtualization"?
Hypervisor is disabled, and it transfer control to the root/dom0 partition, so essentially hypervisor is gone when control comes back to root/dom0 Linux. >>> since control comes back to linux at the callback here, i fail to >>> understand what is vague about it. when hyp completes devirt, >>> devirt is complete. > > This "speak" is what gets on my nerves. You're writing here as if everyone is > in your head and everyone knows what "hyp" and "devirt" is. that's just follow up conversation, commit comment says "hypervisor" and "devirtualization". > Commit mesages are not code and they should be maximally readable and > accessible to the widest audience, not only to the three people who develop > the feature. > > If this patch were aimed at the things I maintain, it'll need a serious commit > message scrubbing and sanitizing first. > > HTH. >
