On Tue, 28 Oct 2025 19:36:02 +0000 Haiyang Zhang wrote: > > Why is the above needed? I thought mana_link_state_handle() should kick > > and set the carrier on as needed??? > > Thanks for the question -- our MANA NIC only sends out the link state down/up > messages when need to let the VM rerun DHCP client and change IP address... > > So, I need to add netif_carrier_on(ndev) in the probe(), otherwise the > /sys/class/net/ethX/operstate will remain "unknown" until it receives the > Link down/up messages which do NOT always happen.
Oh that makes the code make much more sense. Please add this and more detail into the commit message. > + if (!netif_carrier_ok(ndev)) > + netif_carrier_on(ndev); Testing carrier_ok() before calling carrier_on/off is entirely pointless, please see the relevant implementations. BTW I think the ac->link_event accesses are technically racy, wrap them in READ_ONCE() / WRITE_ONCE() while you respin. (Unless mana_hwc_init_event_handler() is somehow under rtnl_lock) -- pw-bot: cr
