On Fri, Oct 31, 2025 at 04:06:32PM -0700, Jakub Kicinski wrote:
> On Wed, 29 Oct 2025 03:37:51 -0700 Erni Sri Satya Vennela wrote:
> > Refactor mana_query_gf_stats() to use mana_context instead of per-port,
> > enabling single query for all VFs.
>
> What does "single query for all VFs" mean?
> All types? All within the host?
Considering the case where there are multiple ports for a single VF,
the details of the Hardware Counters (HC) requested from the hardware
is same across all ports. That is why we have moved the those stats from
mana_port_context (port) to mana_context (VF). I will reframe the commit
message for more readability.
>
> Coincidentally I don't know what HC and GF stand for.
> Please explain things in more detail, all atypical acronyms
> (for *Linux* networking).
>
HC stands for Hardware Counters and MANA_QUERY_GF_STAT is a hardware
command code for GDMA tx LSO packets and bytes count. I will mention it
clearly in the next version.
> > Isolate hardware counter stats by introducing mana_ethtool_hc_stats
> > in mana_context and update the code to ensure all stats are properly
> > reported via ethtool -S <interface>, maintaining consistency with
> > previous behavior.
>
> > -void mana_query_gf_stats(struct mana_port_context *apc)
> > +void mana_query_gf_stats(struct mana_context *ac)
> > {
> > struct mana_query_gf_stat_resp resp = {};
> > struct mana_query_gf_stat_req req = {};
> > - struct net_device *ndev = apc->ndev;
> > + struct gdma_context *gc = ac->gdma_dev->gdma_context;
>
> reverse xmas tree, please
>
Thanks for pointing out. I will make this change in next version.
> > + struct device *dev = gc->dev;
> > int err;
