On 12/8/2025 9:21 PM, Randy Dunlap wrote: > Hi-- > > On 12/8/25 9:11 PM, Yu Zhang wrote: >> From: Easwar Hariharan <[email protected]> >> >> Hyper-V uses a logical device ID to identify a PCI endpoint device for >> child partitions. This ID will also be required for future hypercalls >> used by the Hyper-V IOMMU driver. >> >> Refactor the logic for building this logical device ID into a standalone >> helper function and export the interface for wider use. >> >> Signed-off-by: Easwar Hariharan <[email protected]> >> Signed-off-by: Yu Zhang <[email protected]> >> --- >> drivers/pci/controller/pci-hyperv.c | 28 ++++++++++++++++++++-------- >> include/asm-generic/mshyperv.h | 2 ++ >> 2 files changed, 22 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/pci/controller/pci-hyperv.c >> b/drivers/pci/controller/pci-hyperv.c >> index 146b43981b27..4b82e06b5d93 100644 >> --- a/drivers/pci/controller/pci-hyperv.c >> +++ b/drivers/pci/controller/pci-hyperv.c >> @@ -598,15 +598,31 @@ static unsigned int hv_msi_get_int_vector(struct >> irq_data *data) >> >> #define hv_msi_prepare pci_msi_prepare >> >> +/** >> + * Build a "Device Logical ID" out of this PCI bus's instance GUID and the >> + * function number of the device. >> + */ > > Don't use kernel-doc notation "/**" unless you are using kernel-doc comments. > You could just convert it to a kernel-doc style comment...
Thank you for the review, I will fix in a future revision. Thanks, Easwar (he/him)
