> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Friday, January 9, 2026 8:56 PM
> To: Haiyang Zhang <[email protected]>
> Cc: [email protected]; [email protected]; KY Srinivasan
> <[email protected]>; Haiyang Zhang <[email protected]>; Wei Liu
> <[email protected]>; Dexuan Cui <[email protected]>; Long Li
> <[email protected]>; Andrew Lunn <[email protected]>; David S.
> Miller <[email protected]>; Eric Dumazet <[email protected]>; Paolo
> Abeni <[email protected]>; Konstantin Taranov <[email protected]>;
> Simon Horman <[email protected]>; Erni Sri Satya Vennela
> <[email protected]>; Shradha Gupta
> <[email protected]>; Saurabh Sengar
> <[email protected]>; Aditya Garg
> <[email protected]>; Dipayaan Roy
> <[email protected]>; Shiraz Saleem
> <[email protected]>; [email protected]; linux-
> [email protected]; Paul Rosswurm <[email protected]>
> Subject: [EXTERNAL] Re: [PATCH V2,net-next, 2/2] net: mana: Add ethtool
> counters for RX CQEs in coalesced type
>
> On Tue, 6 Jan 2026 12:46:47 -0800 Haiyang Zhang wrote:
> > @@ -227,8 +232,6 @@ struct mana_rxcomp_perpkt_info {
> > u32 pkt_hash;
> > }; /* HW DATA */
> >
> > -#define MANA_RXCOMP_OOB_NUM_PPI 4
> > -
> > /* Receive completion OOB */
> > struct mana_rxcomp_oob {
> > struct mana_cqe_header cqe_hdr;
> > @@ -378,7 +381,6 @@ struct mana_ethtool_stats {
> > u64 tx_cqe_err;
> > u64 tx_cqe_unknown_type;
> > u64 tx_linear_pkt_cnt;
> > - u64 rx_coalesced_err;
> > u64 rx_cqe_unknown_type;
> > };
>
> This should be deleted in the previous patch already
Will do.
- Haiyang