On 1/13/26 16:41, Stanislav Kinsburskii wrote:
On Fri, Jan 09, 2026 at 12:06:11PM -0800, Mukesh Rathor wrote:
There is no functional change. Just make couple field names in
struct mshv_mem_region, in a header that can be used in many
places, a little descriptive to make code easier to read by
allowing better support for grep, cscope, etc.
Signed-off-by: Mukesh Rathor <[email protected]>
---
drivers/hv/mshv_regions.c | 44 ++++++++++++++++++-------------------
drivers/hv/mshv_root.h | 6 ++---
drivers/hv/mshv_root_main.c | 10 ++++-----
3 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/hv/mshv_regions.c b/drivers/hv/mshv_regions.c
index 202b9d551e39..af81405f859b 100644
--- a/drivers/hv/mshv_regions.c
+++ b/drivers/hv/mshv_regions.c
@@ -52,7 +52,7 @@ static long mshv_region_process_chunk(struct mshv_mem_region
*region,
struct page *page;
int ret;
- page = region->pages[page_offset];
+ page = region->mreg_pages[page_offset];
What does "m" mean here - "mreg_pages"? Is it "memory region"?
If so, then it's misleading, because the same region stuct is used to
the MMIO regions as well. Maybe "region_pages" would be better?
m is for memory or mmio.
Also, while we're at it, maybe rename "mshv_mem_region" to "mshv_region" to
reflect that?
Well, that turns out to be much bigger change, so probably not worth it
now. mmio is "memory" mapped io, so we can probably live with it.
Thanks,
-Mukesh
.. snip ..
