On 1/22/2026 10:40 AM, Breno Leitao wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.Commit 84eaf4359c36 ("net: ethtool: add get_rx_ring_count callback to optimize RX ring queries") added specific support for GRXRINGS callback, simplifying .get_rxnfc. Remove the handling of GRXRINGS in .get_rxnfc() by moving it to the new .get_rx_ring_count(). This simplifies the RX ring count retrieval and aligns the following drivers with the new ethtool API for querying RX ring parameters. * sfc * ionic * sfc/siena * sfc/ef100 * fbnic * mana * nfp * atlantic * benet (this is v2 in fact, where v1 had some discussions that required a v2). See link [0] Link: https://lore.kernel.org/all/[email protected]/ [0] This is covering the last drivers, and as soon as this lands, I will change the ethtool framework to avoid calling .get_rx_ring_count for ETHTOOL_GRXRINGS, simplifying the ethtool core framework. Part 1 is already merged in net-next and can be seen in https://lore.kernel.org/all/[email protected]/ Part 2 is already merged in net-next except benet driver, which is now included in here https://lore.kernel.org/all/[email protected]/ PS: all of these change were compile-tested only. Signed-off-by: Breno Leitao <[email protected]> --- Changes in v2: - Respect reverse xmas tree in Atlantic driver (Brett Creeley) - Link to v1: https://patch.msgid.link/[email protected] --- Breno Leitao (9): net: benet: convert to use .get_rx_ring_count net: atlantic: convert to use .get_rx_ring_count net: nfp: convert to use .get_rx_ring_count net: mana: convert to use .get_rx_ring_count net: fbnic: convert to use .get_rx_ring_count net: ionic: convert to use .get_rx_ring_count net: sfc: efx: convert to use .get_rx_ring_count net: sfc: siena: convert to use .get_rx_ring_count net: sfc: falcon: convert to use .get_rx_ring_count .../net/ethernet/aquantia/atlantic/aq_ethtool.c | 18 +++++++---- drivers/net/ethernet/emulex/benet/be_ethtool.c | 37 ++++++++-------------- drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c | 12 ++++--- drivers/net/ethernet/microsoft/mana/mana_ethtool.c | 13 ++------ .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 11 +++++-- .../net/ethernet/pensando/ionic/ionic_ethtool.c | 18 ++--------- drivers/net/ethernet/sfc/ef100_ethtool.c | 1 + drivers/net/ethernet/sfc/ethtool.c | 1 + drivers/net/ethernet/sfc/ethtool_common.c | 11 ++++--- drivers/net/ethernet/sfc/ethtool_common.h | 1 + drivers/net/ethernet/sfc/falcon/ethtool.c | 12 ++++--- drivers/net/ethernet/sfc/siena/ethtool.c | 1 + drivers/net/ethernet/sfc/siena/ethtool_common.c | 11 ++++--- drivers/net/ethernet/sfc/siena/ethtool_common.h | 1 + 14 files changed, 75 insertions(+), 73 deletions(-) --- base-commit: d8f87aa5fa0a4276491fa8ef436cd22605a3f9ba change-id: 20260121-grxring_big_v4-55037f9e001e Best regards, -- Breno Leitao <[email protected]>
Entire series LGTM. Reviewed-by: Brett Creeley <[email protected]>
