From: Nuno Das Neves <[email protected]> Sent: Friday, January 23, 2026 11:05 AM > > On 1/23/2026 9:09 AM, Michael Kelley wrote: > > From: Nuno Das Neves <[email protected]> Sent: Wednesday, > > January 21, 2026 1:46 PM > >> > >> Introduce hv_counters.c, containing static data corresponding to > >> HV_*_COUNTER enums in the hypervisor source. Defining the enum > >> members as an array instead makes more sense, since it will be > >> iterated over to print counter information to debugfs. > > > > I would have expected the filename to be mshv_counters.c, so that the > > association > > with the MS hypervisor is clear. And the file is inextricably linked to > > mshv_debugfs.c, > > which of course has the "mshv_" prefix. Or is there some thinking I'm not > > aware of > > for using the "hv_" prefix? > > > Good question - I originally thought of using hv_ because the definitions > inside are > part of the hypervisor ABI, and hence also have the hv_ prefix. > > However you have a good point, and I'm not opposed to changing it. > > Maybe to just be super explicit: "mshv_debugfs_counters.c" ?
That sounds good to me. Michael
