On Fri, Jan 02 2026 at 14:02, Mukesh Rathor wrote:
>  
> +#ifndef CONFIG_X86_FRED

This #ifndef is broken. A FRED enabled kernel is no guarantee that the
CPU has FRED. So this has to be unconditional.

> + * Reserve vectors hard coded in the hypervisor. If used outside, the 
> hypervisor
> + * will crash or hang or break into debugger.
> + */
> +static void hv_reserve_irq_vectors(void)
> +{
> +     #define HYPERV_DBG_FASTFAIL_VECTOR      0x29
> +     #define HYPERV_DBG_ASSERT_VECTOR        0x2C
> +     #define HYPERV_DBG_SERVICE_VECTOR       0x2D

As FRED does not need this bit fiddling you want:

        if (cpu_feature_enabled(X86_FEATURE_FRED))
                return;

right here.

> +     if (test_and_set_bit(HYPERV_DBG_ASSERT_VECTOR, system_vectors) ||
> +         test_and_set_bit(HYPERV_DBG_SERVICE_VECTOR, system_vectors) ||
> +         test_and_set_bit(HYPERV_DBG_FASTFAIL_VECTOR, system_vectors))
> +             BUG();
> +

Thanks,

        tglx

Reply via email to