Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit message explicitly claims to add wrappers for 'modifying sparse SPA host access' and 'setting partition properties', but these functions are completely absent from the patch. --
commit 39272e85622d93556ea19a15d2e28e9556ab8c29 Author: Wei Liu <[email protected]> mshv: add SEV-SNP isolated page hypercalls This patch adds wrappers for importing isolated pages and handling their completions for SEV-SNP guests. It supports synchronous and pending completions and preserves the asynchronous completion result while rejecting malformed counts. > mshv: add SEV-SNP isolated page hypercalls > > Add wrappers for importing isolated pages, completing the import, > modifying sparse SPA host access, and setting partition properties. [Severity: Medium] Does this commit message accurately reflect the changes in this patch? The commit message explicitly claims to add wrappers for modifying sparse SPA host access and setting partition properties, but these functions are completely absent from the patch payload. Looking at the changes introduced in drivers/hv/mshv_root_hv_call.c, only the hv_call_import_isolated_pages() and hv_call_complete_isolated_import() wrappers are actually implemented. Are the missing wrappers (such as hv_call_set_partition_property and modifications to hv_call_modify_spa_host_access) perhaps introduced in a subsequent patch, such as 'mshv: wire SEV-SNP partition ioctls'? If so, could the commit message for this patch be updated to only describe the two import wrappers actually added here? This would ensure the patch and its history remain accurate and self-contained. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=5
