Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] mana_detach() unconditionally returns 0 making caller error checks dead code --
commit 69defa182668486dbe34c62749b906b0d4dc31b1 Author: Dipayaan Roy <[email protected]> net: mana: do not bail out of mana_detach on dealloc failure This commit removes the early error return from mana_detach() when mana_dealloc_queues() fails, ensuring that device and port-context cleanup continues. > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c > b/drivers/net/ethernet/microsoft/mana/mana_en.c > index 51f9bfc64c6b3..9297ce15efceb 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -4537,10 +4537,8 @@ int mana_detach(struct net_device *ndev, bool > from_close) > > if (apc->port_st_save) { > err = mana_dealloc_queues(ndev); > - if (err) { > + if (err) > netdev_err(ndev, "%s failed to deallocate queues: > %d\n", __func__, err); > - return err; > - } [Severity: Low] Because mana_detach() now unconditionally returns 0, the error checks in callers have become dead code. For example, in mana_per_port_queue_reset_work_handler(): err = mana_detach(ndev, false); if (err) { netdev_err(ndev, "mana_detach failed: %d\n", err); goto dealloc_pre_rxbufs; } Would it make sense to update mana_detach() to return void and remove the unreachable error handling paths in its callers? > } > > if (!from_close) { -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=9
