-----Original Message-----
From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c-ow...@vger.kernel.org]
On Behalf Of Shinya Kuribayashi
Sent: Monday, October 12, 2009 9:54 PM
To: bar...@tkos.co.il; linux-i2c@vger.kernel.org
Cc: ben-li...@fluff.org; linux-m...@linux-mips.org;
linux-arm-ker...@lists.infradead.org
Subject: [PATCH 15/16] i2c-designware: i2c_dw_xfer_msg: Mark as completed on an
error
As wait_for_completion_interruptible_timeout() will be invoked after the first
call to i2c_dw_xfer_msg() is made whether or not an error is detected in it, we
need to mark ->cmd_complete as completed to avoid a needless HZ timeout.
Signed-off-by: Shinya Kuribayashi <shinya.kuribaya...@necel.com>
---
Or we could change the i2c_dw_xfer_msg() prototype from "void" to "int".
Which is preffered?
drivers/i2c/busses/i2c-designware.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware.c
b/drivers/i2c/busses/i2c-designware.c
index f7ea032..6f85e28 100644
--- a/drivers/i2c/busses/i2c-designware.c
+++ b/drivers/i2c/busses/i2c-designware.c
@@ -376,6 +376,7 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)
dev_err(dev->dev,
"%s: invalid message length\n", __func__);
dev->msg_err = -EINVAL;
+ complete(&dev->cmd_complete);
return;
}
--
1.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the
body of a message to majord...@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
