On Fri, 27 Aug 2010 09:16:07 +0200 Jean Delvare <[email protected]> wrote:

> > +static int akm_aot_open(struct inode *inode, struct file *file)
> > +{
> > +   int ret = -1;
> 
> Useless and dangerous initialization.
> 
> > +
> > +   FUNCDBG("called");
> > +   if (atomic_cmpxchg(&open_flag, 0, 1) == 0) {
> > +           wake_up(&open_wq);
> > +           ret = 0;

this doesn't do anything either.

> > +   }
> > +
> > +   ret = nonseekable_open(inode, file);
> > +   if (ret)
> > +           return ret;
> > +
> > +   file->private_data = akmd_data;
> > +
> > +   return ret;
> > +}
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to