On Fri, Nov 16, 2012 at 12:46:17PM +0100, Wolfram Sang wrote: > On Wed, Nov 14, 2012 at 09:10:33AM +0530, Abhilash Kesavan wrote: > > Hi, > > > > Any comments on this fix ? > > Yes, I agree with Shubhrajyoti here and the code should be refactored so > that gpio initialization is only done once at probe-time unless there is > a real reason to do at suspend/resume.
Note that I just applied a few patches to s3c2410 also touching this area. Would be nice if you could wait a bit until I pushed out my for-next branch later today and base on that. Or wait for 3.8-rc1. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
