On Mon, Oct 21, 2013 at 01:04:32AM -0700, Kuninori Morimoto wrote: > b720423a2627f045133bec39a31fe2bc0dab86f3 > (i2c: rcar: add rcar-H2 support) > added R-Car H2 support on i2c-rcar. > > The R-Car I2C type is based on SoC generation > (Gen1 = E1/M1/H1, Gen2 = E2/M2/H2), > but added naming was H1/H2 instead of Gen1/Gen2. > Gen1/Gen2 is better naming on this driver.
I'd prefer to not change the code, but rather add comments after the
enum types saying this enum applies to the whole generation... Drivers
often start with specific naming. And while things turn out to be more
generic later, IMO it is not worth to keep the naming in sync with
ip-core namings.
> static struct platform_device_id rcar_i2c_id_table[] = {
> - { "i2c-rcar", I2C_RCAR_H1 },
> - { "i2c-rcar_h1", I2C_RCAR_H1 },
> - { "i2c-rcar_h2", I2C_RCAR_H2 },
> + { "i2c-rcar", I2C_RCAR_GEN1 },
> + { "i2c-rcar_gen1", I2C_RCAR_GEN1 },
> + { "i2c-rcar_gen2", I2C_RCAR_GEN2 },
> {},
Renaming the platform_device_ids will cause regressions, too!
signature.asc
Description: Digital signature
